hessenfarmer

in the test suite the scan results of codeql is finished after 2 seconds while the check is still running. maybe there is a depends missing.

@andy5995 do you still want to work on this. @Noordfrees from my perspective this could be postponed to 1.2 as it is no0t a feature but another codechecking / codeimprovement...

maybe I have found some reason for this . dismantling is dependent on miliotary loneliness https://github.com/widelands/widelands/blob/20b0953a10742f5cab5d35cd98412f385a4e8bbf/src/ai/defaultai_warfare.cc#L986 so we should not count constructionsites for loneliness like in this line https://github.com/widelands/widelands/blob/20b0953a10742f5cab5d35cd98412f385a4e8bbf/src/ai/defaultai.cc#L6095 @tibor95...

military_loneliness is used in 3 of 69 scoreparts to determine the Miltiry score of a field, which is used to determine whether to build a Militarysite. I would give it...

well, as should be dismanteled is considered as well. Maybe it is a good idea to add some logging here and analyze first what really causes the issue. But I...

if a Military site is not manned it is better to wait for soldiers rather then dismantle, unless we are far from the enemy.

as this is one of the last big AI bugs, and a most annoying one i would prefer to have a solution in at the earliest opportunity if we find...

Fully understood. So for a quick start we should first add some logging showing the numbers of all variables leading to can_be_dismanteled and should_be_dismanteled. Might be a good idea to...

recent PR's have improved the behaviour of the AI in this topic. However the algorithm was and is dependent on enemy fields in the vicinity. The definition of enemy is...

well it is not an AI definition yet as we use the property from player.cc https://github.com/widelands/widelands/blob/a43d58fdcee287a1883009d7491009b168165e6c/src/logic/player.cc#L338