Juan Hernando
Juan Hernando
Why not using the function htons? It's available in Linux, Mac and Windows
Remove `-GNinja` from the cmake invocation and then use `make` instead of `ninja` to build. The other warning is surprising, because there is a cmake_minimum_required statement in CMakeLists.txt.
This is complementary to any gamma handling related to the color profiles, but somewhat independent. I'm no expert in color handling, but my basic knowledge is that not having any...
1. I think the gamma value should be a user setting. I chose the minimum because the higher the value, the thicker fonts look. I don't have any particular opinion...
> On Mon, Feb 15, 2021 at 12:33:00AM -0800, Juan Hernando wrote: 1. I think the gamma value should be a user setting. I chose the minimum because the higher...
> Using gamma = 2 will make it possible to replace pow with x*x which is chipper and is in the 1.8 - 2.2 range, won't that be a good...
I've been thinking of finishing this PR properly many times, but I didn't find the time and motivation. You're giving a reason to finish it @allemangD. To me it looks...
Now I can reproduce it, in fact I didn't remember I had commented out the code for doing the gamma correction. The interesting thing is that I didn't miss it....
> > what was your motivation for testing this branch? > > I've always had some sense that fonts in kitty seemed "softer" around the edges somehow, and this looked...
Which compiler is printing those warnings. I cannot see any warning with gcc 5.4