Henry Jones

Results 16 comments of Henry Jones

@neutrinoceros Sounds good! I am thinking the deprecation warning should be issued in the Boxlib __init__ file. How does this look? ``` from yt._maintenance.deprecation import issue_deprecation_warning issue_deprecation_warning("The historic 'boxlib' frontend...

@neutrinoceros, thank you for your help. Because the underlying classes and functions haven't changed but have just moved, I have been thinking that the `__getattrs__` method your suggested might not...

> The warnings seem fine (although to be nitpicky I should point out that not just "future work" should be advised to switch to drop deprecated APIs). I would like...

> Not using `__getattr__` is fine, btw. > > Regarding CI, you'll need to edit > > * `pyproject.toml` (specifically `[tool.pytest.ini_options]`) > * `tests/tests.yaml` > > greping for "boxlib" in...

> > this needs to be fixed before we can merge this PR. > > Thanks to @yut23, I understand now that the problem exists on main too, so I...

> > > this needs to be fixed before we can merge this PR. > > > > > > Thanks to @yut23, I understand now that the problem exists...

I made the requested changes to the `_deprecation` file so I think deciding on the tests are the last thing. Thanks!

> Looks like the branch got mixed up with #4848. Also, I don't think the `yt.frontends.boxlib.test` module should raise a deprecation warning: when I was running pytest locally, it raised...

> The branch history looks confusing, I see several commits from other branches that I think we're merged already. Do you mind if I try to clean this myself ?...

> Ok I just rebased and purged out dupe commits as requested. I'm not sure exactly what happened during your attempt I suspect you forgot (or didn't know) to resolve...