Joseph Hendrix comments

Results 5 comments of


                                            Joseph Hendrix

Lang 1689 add optional to objectutils isempty

I was thinking about this, and if we wanted to look at the contents of the Optional rather than the optional itself, there are three ways I've though of doing...

Lang 1689 add optional to objectutils isempty

I create another PR (#934) that uses the approach mentioned in my previous comment (using the non-recursive way) instead of looking at the optional itself. I'm unsure which is the...

Cycle detection doesn't catch cycles through collections

I have a fix for this (plus a unit test), as well as a couple other locations this might still be happening. I'll try to make a PR tomorrow. Can...

Issue 652 cycle detection doesnt catch cycles through collections

The [Java 8 test build](https://github.com/stleary/JSON-java/actions/runs/3291548305/jobs/5425848970) did fail due to those two intentionally failing tests; let me know if you want me to add `@Ignore` to them.

Issue 652 cycle detection doesnt catch cycles through collections

> @hendrixjoseph Sorry for not responding sooner. Failing unit tests are a concern. What is the performance cost of this change (how much does it slow things down)? I added...