Ben Lee-Cohen

Results 38 comments of Ben Lee-Cohen

I'm also here from Eleanor's roundup, and this is a gorgeous theme. I'm keeping an eye on the approval, but using it locally until then. Thanks for your attention to...

+1 for this PR. Currently I'm working around by chaining uniq every time I call accessible_by in one of these cases.

This PR is really the only thing keeping me on `tig` -- @willir is there any chance you'll be able to revisit it this year?

Echoing @EpocSquadron -- I like having a single place to go for symbols, and falling back to treesitter when there's no lsp would be amazing.

@QiBaobin I just tried this PR, and it's great. One possible improvement: today, if there's no lsp for a language, you get an error on the symbol picker. But with...

Possibly extend this to all rolls to solve #74 as well.

> Will do. I'll report back if I find the cause @ryanneph did you find the source of this issue? I'm seeing the same thing.

I love this PR -- is there anything else that would be useful from a testing or feedback perspective?

Right, I meant tree sitter, good correction. But I wasn't clear if @archseer was saying it should also work on raw text as well: ![Screenshot_20211115-204257.png](https://user-images.githubusercontent.com/70898/141880650-22e6214e-4820-4bda-99ad-55b8437d595f.png)