Harry Doan comments

Results 18 comments of


                                            Harry Doan

Create LICENSE

Btw, thanks you for this post https://www.eliotsykes.com/test-rails-rake-tasks-with-rspec It made testing rake task easy!

Add cursed methods to Rails models

Since they aren't really used, there is little value to generate them, except to clean up hidden.rbi file. If you'd like to clean these up properly, feel free to contribute...

Add cursed methods to Rails models

Yes. I think it's useful to have it as a plugin, for completeness. We don't have to make it a default plugin, but can add a line in Readme to...

Add cursed methods to Rails models

We should rename it :P IDK what's a good name though, something like AllOtherUselessMethodThatRailsAddedPlugin lol (j/k) On Tue, Oct 8, 2019 at 6:20 PM Harry Doan wrote: > Yes. I...

Non-optional belongs_to relationships can still be nil

There is a class of issues with a newly created or unsaved record (`Sale.new`). I'm thinking about how to deal with it, eg we have 2 type: Sale and UnsavedSale....

Unable to resolve constant Parser

@scottjg Thanks for reporting the issue! Parser is a dependency that is specified in `sorbet-rails` gemspec. Can you check if you see parser in your Gemfile and you have a...

Type of Rails.application should be YourApp::Application

Sure! I think this is a valid change. We probably want to introduce a new generator for this On Thu, Jul 25, 2019 at 2:03 PM Bradley Buda wrote: >...

Feature: Re-generate model RBIs on db:migrate

I've tried building something like that before. I think it was a bit slow to run as part of db migration. It is an incomplete solution, since it doesn't cover...

rbi:models generates a String type sig instead of T.nilable(String)

@benjamin-thomas Yeah, I agree this behavior can/should be configurable. We have a [config](https://github.com/chanzuckerberg/sorbet-rails/blob/18a78e67eff77acecb1108b50fe28df07a13a8b3/lib/sorbet-rails/config.rb) object. I think we can add an option there.