Michael Hayes

The insider preview updates every day https://code.visualstudio.com/insiders On Mon, Oct 3, 2016, 7:04 PM Blaine Schmeisser [email protected] wrote: > I downloaded visual studio code 1.5.3 onto a windows 10 box....

Sorry, opened this as a draft since I had some somewhat reasonable code, but probably not ready for a real review yet. Mostly just opening it for sake of discussion...

@dotansimha was going to wait until there was a clear path forward on #1248 before spending too much more time on this

That seems like a decent alternative to me. In my opinion, the upside of having something like envelop is that it has the potential to standardize, abstract, and enforce best...

If this is a direction that you want to go, I am happy to help update plugins to use this convention

@n1ru4l Cool, happy to work on this. I started experimenting with this here: https://github.com/hayes/envelop/pull/1/files Some things I noticed: If we want to use mapSchema, we would need to add that...

I'm not sure what that means for the use-timing plugin since its part of core. I see 4 paths forward: 1. Remove plugins that depend on wrapping resolvers from core...

@n1ru4l Are you against the idea of creating a way to map revolvers that does not depend on an external dependency? I am hesitant to introduce more breaking changes than...

I ended up writing https://pothos-graphql.dev/docs/plugins/tracing because I was not clear on a path forward here. The more I think about it though, I like the separation between using envelope for...

I ended up starting from scratch, I think my requirements are probably outside the scope of what would be easy to achieve through pull requests to this (or any other...