Tobias Deiminger
Tobias Deiminger
> Regarding the the problem with the duplicates, when there are conflicts in make_unique_test_ids pytest disambiguates them with a suffix. This should probably also be done for parameter keys then,...
@bluetech Thanks for taking your time! That was a really helpful review. Most of the remarks are hopefully done, and the commit series is rebased on latest main. I left...
> if you agree, I can cherry-pick it to main already, to reduce the size of the remaining PR. Just applied your recent comments. Sure, cherry-pick it, or in case...
@bluetech Sorry for delay in response. > the example in the first commit message is not very fitting Agreed, my example not only missed `scope="module"`, but also contained syntax errors....
> but WDYT? Sorry for the edits in yesterdays answer. They make decision even simpler: We can trade the current `SafeHashWrapper` approach for a documentation statement _"Provide ids, else your...
> @bluetech @haxtibal gentle ping to get this rolling again (or close, if deemed best). I'd still be interested and standing by. @bluetech How about you?
@Al2Klimov Not sure I understand correctly > For me a filter which did **not found** any objects is a 404 **not found** Got that. > a permission denied is the...
Would it be possible to add a short statement to [the quantized-mesh-1.0 spec](https://github.com/AnalyticalGraphicsInc/quantized-mesh), explaining the reasoning for using zigzag encoding without VLQ? Something like "gives (very) minor size reduction when...
This issue also prevents report logging. The `Captured log call` section was quite useful, but since we use `propagate = False` it remains empty. So far I can only workaround...
> It should be possible to test different loggers in different tests. My comment was not about testing loggers (what one would do with `caplog`, using the [caplog_handler](https://github.com/pytest-dev/pytest/blob/34765f6b2e8a98b231baa33e4f356646259ab556/src/_pytest/logging.py#L554) under the...