Hassan comments

Results 10 comments of


                                            Hassan

Documentation when parsed is null?

Yes, it returns null when XRegExp doesn't find any match.

Doesn't identify 9 digit zips

In the original Perl implementation the ZIP+4 code is parsed but later stripped out. This library also behaves the same. But I'm open to keep the ZIP+4 code as additional...

Doesn't identify 9 digit zips

Can you try it on `zipplus4` branch? https://github.com/hassansin/parse-address/tree/zipplus4

Fails to parse certain US address (Like the ones on Highways)

I'm getting following for the above address: ``` js { street: 'N95W18000 Appleton', type: 'Ave', city: 'Menomonee Falls', state: 'WI', zip: '53051' } ``` Is it supposed to be different?

Pasting long lines to wrapped view inserts unwanted newline characters on linux

Hi, #188 might also fix this bug.

Won't switch to polling transport when Websocket transport failed

@darrachequesne okay, so if Websocket is blocked by proxy and unable to connect, shouldn't it switch to polling?

Won't switch to polling transport when Websocket transport failed

Anything? What's the point of having multiple transports if automatic switching doesn't work?

Session store not set on request.

This library stores cart items in session storage. So you need to have sessions enabled to use this library.

Won't switch to polling transport when Websocket transport failed

@darrachequesne okay, so if Websocket is blocked by proxy and unable to connect, shouldn't it switch to polling?

Won't switch to polling transport when Websocket transport failed

Anything? What's the point of having multiple transports if automatic switching doesn't work?