Haram Park
Haram Park
> Hi & sorry for the delay ! > > This looks really good, however: > > * you need to add some tests (see `test/scapy/layers/bluetooth.uts`) > * you have...
> You can build a packet and check the results of the raw bytes, or dissect bytes and check the results of the packet. > > There are plenty of...
 Hello, this is Haram. Could you please help me? Let me know what I have to change.. I didn't modify import.uts.. but there is a error... I'm waiting for...
> Hello ! > This is probably unrelated, you can likely ignore it. Ah, thanks for quick response. Then, what should I do now? Haram Park.
> I had a look at the PR. It seems that some changes are only cosmetic. Could you revert them? I did, please check it. Thanks.
> The code have PEP08 related errors https://github.com/secdev/scapy/pull/3250/checks?check_run_id=3721770792#step:5:12 > > Could you fix them? I fixed it, please check it..
> The code have PEP08 related errors https://github.com/secdev/scapy/pull/3250/checks?check_run_id=3721770792#step:5:12 > > Could you fix them? I need your approval.
> The code have PEP08 related errors https://github.com/secdev/scapy/pull/3250/checks?check_run_id=3721770792#step:5:12 > > Could you fix them? Since I need your approval every time, it takes a lot of time. Can't I proceed...
> `tox -e flake8,mypy` I did it in local.. thanks! so now I don't have any pep8 error....!! I need your approval for workflow..! Check it please, thanks! Haram Park
> You can run the PEP8 & mypy tests locally using > > `tox -e flake8,mypy` > > This would have been more efficient Now, I have no more pep8...