xu0o0

Results 40 comments of xu0o0

> this changes existing functionality right? This PR should not change the existing functionality. It just changes the params for getting pages to expand the `restrictions` property. So we don't...

I no longer follow this PR. It is ok to close it.

A crashed or misbehaving client may cause connection/goroutine leaks in the OpAMP server (open-telemetry/opamp-go#271). A heartbeat mechanism can help the server find out unresponsive peers and also defend against intermediaries...

I try to draw a sequence diagram of case 1: ```mermaid sequenceDiagram participant Client participant Client.Receiver participant Client.Sender participant Server Client->>Client.Sender: (1) c.SetAgentDescription in `prepareClient` call `sender.ScheduleSend()` Client->>Server: (2) AgentToServer...

> the dummy message is only sent after the the first asseetion passes `assert.Eventually()` does not terminate the test even the assertion has failed. So we can always see the...

The first assertion is used to check whether the server has received the original uid. In the timeline case 1, the server has received the original uid, the first assertion...

> It could be because no value was set to `rcvAgentInstanceUid` and the assertion failed. If no value was set to `rcvAgentInstanceUid`, both the `eventually` assertions will failed. In the...

https://github.com/haoqixu/opamp-go/tree/debug-pr-216 I have submitted some test log to this branch.

``` 2023/12/05 23:33:17 test begin 2023/12/05 23:33:17 client: SetAgentDescription and ScheduleSend 2023/12/05 23:33:17 old instance uid is 01HGX9SCX1EQPHGGJ9X6Y1JSTY, starting client 2023/12/05 23:33:17 client: send message at Start 2023/12/05 23:33:17 server:...