Haoming Meng comments

Results 14 comments of


                                            Haoming Meng

feat: add canvas as option to Viewer constructor

Closed with #584 open

[wip] Upgrade to threejs 134 - after ES classes

Are we still working on this PR or does it paused/stoped for some reason? Appreciate any clarification!

MarkerArrayClient out of memory

Hi @chenfubiao how did you work around with the texture?

Add canvas as option when initialize Viewer

@MatthijsBurgh Hi there. Would you have time to help me review this PR? Thanks!

[WIP] Convert to ESM and ES classes

Any updates regarding this PR? Thanks

Make timeout for `hashFiles()` configureable

Any updates for this issue or this should be closed? We caught the same error and suspect our runner fails because we have large files to hash and it could...

added canvas as option to the viewer

Hi @MatthijsBurgh, could you please review this PR at your convenience? Thanks.

added canvas as option to the viewer

@MatthijsBurgh Appreciate all the suggestions! Made the modifications and please help review it at your convenience. Thanks!

added canvas as option to the viewer

@MatthijsBurgh Sorry about that. Reverted build files to the previous commit. (Apologies for the typo in the commit message)

added canvas as option to the viewer

I’m working on identifying the issue and wrote additional tests to make sure the Viewer itself can pass the CI test. Could you help approve the workflow? Thanks. @MatthijsBurgh