Hanson Wang

Results 43 comments of Hanson Wang

FWIW the current published spec also says: > The code action request is sent from the client to the server to compute commands for a given text document and range....

This should be a pretty simple PR for anyone interested! The logic that implements the status bar counters is available here: https://github.com/facebook-atom/atom-ide-ui/blob/f2d921a9cc4710b440b8ec468fd6eca50d989e53/modules/atom-ide-ui/pkg/atom-ide-diagnostics-ui/lib/ui/StatusBarTile.js#L107-L117 The 'current file' toggle is stored as an...

Markdown datatips are converted to HTML via `marked` here: https://github.com/facebook-atom/atom-ide-ui/blob/master/modules/atom-ide-ui/pkg/atom-ide-datatip/lib/MarkedStringDatatip.js#L32 If there are any parameters which would enable `atom://` links to work, I'm open to merging that in!

Ah, this is the first I've heard of it! This definitely makes sense, doesn't sound too hard to make an adapter for these :) On Wed, Apr 18, 2018, 11:59...

I'll look into this - I enabled sanitization for fear of JS injection but that may not be a concern. (I imagine there is a flag to enable HTML but...

Ah, I'm not sure how to do this. `marked` doesn't come with any builtin mechanism for basic HTML (related issues without answers: https://github.com/chjj/marked/issues/527, https://github.com/chjj/marked/issues/1037). The security consequences here aren't so...

Sounds like a great candidate for a community contribution :) Just for reference, what interface does atom-linter use to expose this functionality?

Yup, seems like a great configuration option / PR candidate! We've made this the default to play nicely with Nuclide's debugger functionality, which also puts breakpoints on the left -...

Unfortunately there isn't a great solution for this in the Flow-typed world. Ideally we could have a `@typed/atom-ide-ui` you could install or something like that.. maybe I'll make a `atom-ide-ui-types`...

They are copy pasted, hence the need for this issue :) You can probably just copy+paste them as well as a short-term solution.