Hannes Voigt-Georg

Results 22 comments of Hannes Voigt-Georg

Hi Sean, Hi Bastien I considered writing a patch for that but I have one question. Shouldn't `HeaderValue::from_bytes("coucou \t ".as_bytes())` rather return an error? The rfc is about what parsers...

Yep, I agree. I left it out at first because I didn't see the immediate value, but now I some pointful usecases.

Okay, I've implemented something in the 0.6.0 release. Please test and report if something doesn't work like you expect it.

Hm, how should this case be handled: ``` URITemplate.new('{?x,y}').expand_partial(y: 'z') ``` `{?x}&y=z` is not guaranteed to issue a leading questionmark.

I guess you're right. Just because the example code uses the order of the variables doesn't mean it's mandatory.

Hi, I've written some more code and some more specs. I've also grant you push access in case you want to add some more specs or change the behavior.

Hi @andreypopp Have you tested the changed behavior? Can you give me some feedback?

Hi The colon template in uri_template is currently ultra-simple, so this isn't currently possible. I think it would be great if that was possible. My initial idea for the colon...

Hi @andrewpthorp Any progress so far? Can I help?