Han Fei

Results 17 comments of Han Fei

Well, Is there a better way to print log ?

Another case in production enviroument ``` create table t1 (id Int32) Engine = MergeTree() ORDER BY id; create table t2 (id Int32, c String) Engine = MergeTree() ORDER BY id;...

@rschu1ze PTAL again. I didn't update the docs yet (let me do it later). Maybe I didn't address all the comments because it's too many to remeber to fix them...

@alexey-milovidov maybe I need your approval, otherwise it cannot be merged

May I ask what kinds of correlated queires are supported here? In my mind, de-correlated is like transfering ``` select * from t1 where 0 < (select count(*) from t2...

@rschu1ze I fixed `02124_insert_deduplication_token_multiple_blocks.sh` but forgot this one :P

Hi, I would suggest execute `optimize table` without `on cluster`. Then the merge will propagate properly

@ucasfl because the error happens in our private ci log server which uses shared merge tree. it returning a logical error makes our open source ci server crash :(

@rschu1ze I think convert types in every `estimate` function in every statistics is redundant.

I suggest merge this PR https://github.com/ClickHouse/ClickHouse/pull/67858 first, because 1. it only fixes CI, without a new feature 2. it puts type convertion to one place, which is more beautiful.