Halil Kaya comments

Results 9 comments of


                                            Halil Kaya

fix: avoid creating some resources if runners_executor is not docker+machine

Hi @npalm , could you please review this MR? I'd like to hear your feedback.

fix: avoid creating some resources if runners_executor is not docker+machine

@npalm It was my bad. I pushed a new commit that contains fix for that error and some `terraform fmt` changes as well. `terraform validate` should no longer throw an...

fix: avoid creating some resources if runners_executor is not docker+machine

I think it's failed because of formatting it with the newer version of Terraform. I re-ran the `terraform fmt` command with Terraform 0.12 and pushed it. `Verify module` step should...

fix: add dnsPolicy to Deployment

> Hey @halilkaya, could you please run `make reviewable`? CI reports a diff in the helm chart README. > > ``` > M deploy/charts/external-secrets/README.md > ``` I ran and pushed...

You are right, actually. I though it first, but didn't want to change the structure. We can use [EasyDict](https://pypi.python.org/pypi/easydict/) to use data with dot notation in Kaptan. If it's OK...

add and remove methods added

@tony sure. It had better be optional for backward compatibility. I'll do that. :)

add and remove methods added

@tony sorry for not dealing with this for a while. I've searched a little bit about using dot notation in Python dicts. But all the results suggest to use default...