Matt Oliver

Results 30 comments of Matt Oliver

Looks like this is breaking a ton of stuff...hmmmm

So it looks like reverse is reversing within an operation (as evident by the tests) but it's not reversing when chaining operations

@nafg I think I actually identified the root cause as https://github.com/nafg/slick-migration-api/blob/master/src/main/scala/slick/migration/api/Dialect.scala#L184 Sorting by the Action sort value is forcing order regardless of the appended order of the actions. Removing the...

The alignment of all the dependency versions were correct except for that one haha.

@nafg yeah so my proposed solution was to add a `reverse` to the `migrateTable` function and if you've reversed the table, it'll reverse the sort of the sql strings https://github.com/nafg/slick-migration-api/pull/87/files#diff-e597e55948ec9df1caeac6f1b01e9040R184...

Ok @nafg this should be good if you're ok with the solution. It looks like on every db except Postgres, you can't create, add and then remove all columns (there...

@nafg Ah sorry I think I had mis-understood what you were originally talking about. I played around with the weights (sort values) and have verified locally it now works for...

It tests that a successful reversal of multiple chained migrations works. All of the other test examples, afaik, only test the reversal of one migration. Due to db mechanics for...

We could detect a drop table and then just drop any drop column actions from the actions list...we probably could just drop all other actions since dropping the table is...

Yeah I think that's a fine approach. So you'd detect whether a drop table action has been queued and then essentially remove any drop column actions and proceed as normal.