huhaiyang comments

Results 35 comments of


                                            huhaiyang

HDFS-16775.Improve BlockPlacementPolicyRackFaultTolerant's chooseOnce

Hi @Hexiaoqiao @ZanderXu @tomscut @tasanuma @ayushtkn please help me review this pr when you are available, Thanks.

HDFS-17401. EC: Excess internal block may not be able to be deleted correctly when it's stored in fallback storage

please fix checkstytle, thanks~

HDFS-17401. EC: Excess internal block may not be able to be deleted correctly when it's stored in fallback storage

In` BlockManager.java`the variable `logEmptyExcessType` seems unused can remove?

HDFS-17401. EC: Excess internal block may not be able to be deleted correctly when it's stored in fallback storage

From my side seems well, except for some small issues in test UT. please @zhangshuyan0 help review it again, thanks~

HDFS-17401. EC: Excess internal block may not be able to be deleted correctly when it's stored in fallback storage

Please fix checkstytle and the UT failed issue, thanks~

HDFS-17352. Add configuration to control whether DN delete this replica from disk when client requests a missing block

The result of the CI is here. The failed tests seem not to be related. https://ci-hadoop.apache.org/blue/organizations/jenkins/hadoop-multibranch/detail/PR-6559/3/tests

HDFS-17352. Add configuration to control whether DN delete this replica from disk when client requests a missing block

Update PR to support dynamically configured. Hi @ZanderXu @tomscut please help review it again, thanks~

HDFS-17352. Add configuration to control whether DN delete this replica from disk when client requests a missing block

The failed tests seem not to be related.

HDFS-17352. Add configuration to control whether DN delete this replica from disk when client requests a missing block

Hi @ZanderXu @tomscut @zhangshuyan0 @tasanuma please help me review again this PR when you are free, thanks ~

HDFS-17352. Add configuration to control whether DN delete this replica from disk when client requests a missing block

Hi @Hexiaoqiao Sir would you mind look it again, thanks~