Haitao Chen

Results 21 comments of Haitao Chen

so these 2 condition (longRunningOperation, and defining 400 with responses section) should not be combined together, we need to kick out one of them, I vote to kick out ```"x-ms-long-running-operation":...

> The docs indicating that 400 returns a DeploymentValidateResult seems anti-HTTP and bad design. 400 means that the operation did not work at all. exactly, this should be a 200...

@emicklei this should reduce the burden of maintenance. dependabot - is helpful to keep go mod up to date. - is also helpful to keep update github workflows, we only...

> why was the target branch removed? apparently some copy-paste error, while lost tracking v3 is the default branch.

After dig into the code, I think the key is `func (c CurlyRouter) regularMatchesPathToken(routeToken, colon, requestToken)`, where it try to match a requestToken `xxxhello` to a routeToken `{h:(?i)hello}`. in my...

did find a workaround by using more strict regex `{h:(?i)^hello$}`, the ^$ would ensure whole token match.

send PR with example on how to handle this issue safely #546

thanks for merging the example PR, hopefully that will help someone. As a library, I think we want to prevent caller from make mistakes and cause misroute, can we consider...

created PR https://github.com/kubernetes/release/pull/3758

3 image promotion PR: - https://github.com/kubernetes/k8s.io/pull/7324 - https://github.com/kubernetes/k8s.io/pull/7323 - https://github.com/kubernetes/k8s.io/pull/7320