haiqi96
haiqi96
Thanks for making the change, it now makes much more sense to me
Trying to think about this from another perspective, what if we rearrange the code, such that we have a function, takes in the `target`, the `exclude`, and generates a List:...
> What's the status of this PR? I guess Junhao got too busy on other stuff and this gets deprioritized
looks good to me. I don't have any specific concern
A high level comment: Methodlogy wise, I feel the rest of our code tend to let caller check if the data_block is empty, rather having a function to read the...
> > A high level comment: Methodlogy wise, I feel the rest of our code tend to let caller check if the data_block is empty, rather having a function to...
A high level concern is that what would be good terms to distinguish, (1) a general job name launched by decompress.py script" (2) a job that decompress a file, and...
> How do we specify `target-uncompressed-size`? I tried `./decompress.sh i --target-uncompressed-size 10240 --orig-file-id daf326b3-ab77-42ec-9fcf-056b541f948a 0` and also manually inserted a msgpack record of > > ``` > { > "orig_file_id":...