hai-x

Results 26 comments of hai-x

Can't dynamically import a node module with a variable

It will get some warnings. > The above dynamic import cannot be analyzed by Vite. See https://github.com/rollup/plugins/tree/master/packages/dynamic-import-vars#limitations for supported dynamic import formats. If this is intended to be left as-is,...

fix: add return value to `subtractRuntime` fn

Sorry for delay. Try adding a test case, but can't find a specific case that can hit this logic (`a` is SortableSet, `b` is string). But I try to use...

fix: add return value to `subtractRuntime` fn

> @hai-x hm, can you provide manual steps to reproducible it I will think how we can test it, thank you and sorry for delay Reproduction steps: 1. git clone...

when setting `optimization.providedExports` to false, outputModule wouldn't generate export statement

I found that the issue has always existed since version [5.41.0](https://github.com/webpack/webpack/releases/tag/v5.41.0) which add EcmaScript modules support. I'm willing to fix this issue, and I've spent some time looking at it....

webpack Tree Shaking 的实现原理

再次阅读，受益匪浅。

webpack tries to resolve `new URL('./', import.meta.url)` to a module and fails or succeeds (both are wrong)

> PR welcome to fix it Could we add one leading ignore comment to opt-out url parsing [just like what `rolldown` does]?(https://github.com/rolldown/rolldown/issues/2745)

FlagDependencyExportsPlugin is slow with large JSON imports

After look into this issue in depth > Allow a maximum export depth to be specified in the webpack config for JSON files webpack 4 only computed top-level exports for...

FlagDependencyExportsPlugin is slow with large JSON imports

@alexander-akait > We can implement a new parameter - deep, development - for the developer mode I think parameter 1 is the most suitable, for the production - infinity. What...

FlagDependencyExportsPlugin is slow with large JSON imports

> @hai-x `depth` is good for me 👍 I will open one pr soon.

`parser.hooks.new` not called for classes within the same file.

I think we should not rely on `innerGraph`, even if user set`innergraph` to false, `new` for `NotWorkingClass` also should be called.