Jonas Hahnfeld
Jonas Hahnfeld
> Is memory unmapping enabled? Is GC incremental mode enabled? > Probably for debugging purpose, it worth to disable these 2 features. As far as I can tell, the default...
FWIW `--disable-munmap` didn't change anything if I remember correctly. Neither did building bdwgc as a shared `.dll` and not as a static archive, to get a properly working `DllMain`. This...
Good idea. Will you implement it per scope? Just cosmetic: Why 2 dots in the config name? Maybe just git-ftp.ignore-gitfiles with a dash?
Well, why would you want to have it available? It's not needed and it's (maybe) exposing information about your directory structure (location of you git-ignored config file for example; don't...
I'm tentatively assigning @agheata (because it's geometry) and @Axel-Naumann as we briefly discussed during the team meeting if it makes sense to fix this or deprecate and drop the code...
> Technically code works with all 3.x versions of `nlohmann/json.hpp`. I add requirement for 3.9 recently just because we were not using and not testing for `json_fwd.hpp`. Now version restriction...
@linev as I said in https://github.com/root-project/root/pull/11268#pullrequestreview-1088542373 two weeks ago, I approve the fix for `fail-on-missing`. I'm not happy about the other changes (in particular, I don't understand why we would...
> > and I disagree with the references to the "LLVM upgrade" solving something with nlohmann/json.hpp - this never stood up to a factual check. > > I did check...
> > What did you check, and what worked? Did you build a module? For me, LLVM 9 and LLVM 13 give the same result: including json.hpp into a header...
I've tried some more, and I think the problem is indeed related to the memory page scanning and threads on Windows: My understanding is that, to find data sections of...