Hadriel Kaplan

fbstring does not handle append/insert with aliasing iterators

1

I'm using an older `folly` version and haven't tried reproducing this for latest, but looking at the latest code for it it looks like the same issue still exists, so...

Segfault if base language flags given while new subparser uses `{dedicated}` mode

5

`ctags` segfaults given the following options.ctags and a `.cpp` file to parse: ``` --kinds-C++=* --langdef=Test{base=C++}{dedicated} --map-C++=-.cpp --map-Test=+.cpp --_tabledef-Test=main --_mtable-regex-Test=main/.// ``` If the `--kinds-C++=*` is removed, it works fine. If it's...

Some compiler warnings are generated

1

@Naios This is relatively minor, but I thought I'd mention it before I forget about them: building `function2` strictly as a copied header with `clang` can trigger a few warnings,...

Still having some issues with macros, as well as other things

6

Hi, I was hesitant to raise this issue because I was so happy the recent regression for C-macros was fixed, that I was mentally ignoring any other problems. :) But...

Max float encoded into JSON cannot be decoded back again

1

Hi, using the protobuf C++ API on a Centos system, encoding a `FLT_MAX` value into JSON yields: ```json { "float_value": 3.4028235e+38 } ``` ...but when deserializing that back into protobuf,...

trait IsZeroInitializable is incorrectly true for unions

1

`folly/Traits.h` has this: ``` template struct IsZeroInitializable : std::conditional< traits_detail::has_IsZeroInitializable::value, traits_detail::has_true_IsZeroInitializable, bool_constant::value>>::type {}; ``` A `union` is not a class, and thus `!std::is_class::value` results in `true`, making a `union` zero-initializable....

Docs: get rid of the optlib man page and just point to docs.ctags.io

3

I was updating the `man` page for `optlib` (`man/ctags-optlib.7.rst.in`), and it feels very redundant with the optlib "Extending ctags" chapter of http://docs.ctags.io, mostly from `docs/optlib.rst`. So I'm wondering: why do...

A recent commit bea73e236ce14e36bca7cc28e644ff928856adb3 added the `insert_or_assign()` method to `folly::sorted_vector_map` in `folly/sorted_vector_types.h`. But it is returning an `iterator` instead of `std::pair` as [`std::map` would](https://en.cppreference.com/w/cpp/container/map/insert_or_assign). Only the overload with a `hint`...

We're using an older version of TANK than the current head, but it looks like the problem persists even now... `tank_client.h` `#include`s `Switch/switch.h`, which `#define`s the following macro names: ```cpp...

Yet another binding, and some issues

3

Hi, This is more of a courtesy message than anything else - I'm not sure if you're still updating lrexlib these days or not. (?) I write code for an...