Jason Gustafson
Jason Gustafson
@hshi2022 Thanks for the patch. Did you catch this deadlock in practice or did you use some tool to find it?
@hshi2022 Yeah, we are often fighting some flaky tests. It should not block merging if they are unrelated. Can you take a look at the response above https://github.com/apache/kafka/pull/12634#discussion_r982935129? Thanks!
Kicked off one more build since it's been a little while. I will merge assuming nothing wrong with the build. Thanks for the patch!
I started one more build since the last one had a bunch of failures due to a lingering thread.
Yeah, makes sense to me. Maybe we can add: GET /consumers GET /consumers/{groupId}/instances Might also be helpful to have a way to query current offsets: GET /consumers/{groupId}/instances/{instanceId}/offsets
@ewencp I'm not sure I see any problem with having `GET /consumers` return the full list of groups in the cluster, but it's definitely trickier if we wanted to implement...
Thanks for all the discussion here and sorry for the late arrival. I have seen this issue in practice as well, often in the context of hanging transactions. The late-arriving...
@lqjack Can you merge with trunk please?
I think this is a good change. Probably the only case it may have made sense is some of the broker produce/fetch error handling. It's probably worth taking a look...
@dengziming Thanks for the investigation. One idea I was considering is only letting observers fetch up to the high watermark. Then the records would be returned to brokers as they...