Konstantin Gvencadze
Konstantin Gvencadze
@axw hey, I've signed CLA (tried with both of emails that's linked to account), but nothing changed. Do I need to restart pipeline or something else? UPD: merge latest changes...
@axw hey, I've done what you've write about above: 1. integration tests are already presented in `tracer_test.go`, they're located under `TestLog` 2. `make update-licenses update-modules fmt scripts/Dockerfile-testing` - done, but...
@axw I've added e2e tests for Query and Copy tracing, only the batch trace remain. Can you take a look? Maybe you will find something else that should be changed/discussed
> @gvencadze there's an issue with formatting, CI is failing with this error: > > ``` > [2022-09-27T17:20:32.075Z] goimports differs: > [2022-09-27T17:20:32.076Z] - module/apmpgx/e2e_test.go > ``` > > Can you...
@axw done Also, If we want to create another one module for pgx (but for v5 version), should we open issue and link it with MR or not? Current module...
Recommendation was showed in log of running golint in github CI. Or better I should just add link to revive (instead of removing) and write that golint is deprecated? >...
@johanbrandhorst yeah, I'm interested in contributing to open source :) I've created MR which contains reproducible example