Gus Wynn

Results 62 comments of Gus Wynn

what was the pr that moved `remote` to `HostConfig`? I missed that, and just want to check it out first

> but it might make sense to simply ignore the command if it tries to set the search path to public anyway. This is what we do for `NAMES =...

@benesch thanks for the notes, very helpful! > We probably want FrontierUppers to include upper information for both the remap shard and the data shard. That will allow us to...

> Whatever get_resume_upper currently does is right! So the idea is: - For new sources, we use `get_resume_upper` to get the resumption upper, and add that to the - We...

After collecting feedback on my first pr from @aljoscha, @frankmcsherry, and @benesch, here is an overview of what I think the implementation of this epic entails, followed by some important...

@fredr do you mind telling me what `LevelFilter::current()` is in the latest repro (the `MyLayer` one), as well as in your real application?

@YaLTeR do you mind posting what `LevelFilter::current()` is with the profiling layer `None` and `Some(_)`? I have a hunch this is a similar bug to https://github.com/tokio-rs/tracing/pull/2193 (also, what versions are...

Sorry about the delayed response here eveyone: I did find time to look deeper into this and believe to have found the culprit broken code in the `Layered` impl. My...

@hawkw the fix is basically to add `?` on the 2 values here before comparing them https://github.com/tokio-rs/tracing/blob/master/tracing-subscriber/src/subscribe/layered.rs#L497 this passes all tests except for 1 test on the fmt layer, which...