Giovanni Tataranni

Results 13 comments of Giovanni Tataranni

it was with c++ language files (extensions c/cc/h/hh)

silly attempt to make it work by modifying line https://github.com/richterger/Perl-LanguageServer/blob/master/lib/Perl/LanguageServer/SyntaxChecker.pm#L243 seem to work ```perl $ret = run_cmd ([$self -> perlcmd, '-T', '-c', @inc],

> What is the real case it would be helpful? This is useful for integrating with observability stacks, as [logfmt](https://www.brandur.org/logfmt) is a common format for machine-readable logs. It enhances log...

@ton31337 Changes done, please review

> While this is OKay-ish, we should also align with upper releases too... you mean opening the same (similar) PR towards `stable/10.0` and `stable/10.1` too? I can do that, if...

> Backport should only contain bug fixes. I see formatting and other changes too. Removing formatting changes will take me more time now and more time from next developer who...

> Also, frr-reload is just a python script, if you really want all of these changes, why not just copy the script directly into the systems where you want it?...

OK, I will review the commits to not/include in this PR, so to include only fixes, and re-request review. I will do my best exclude those changes not related to...

@Jafaral Changes done, please review again. No rebase needed as this PR is against stable/8.5, and there are no changes there. However, we'd like to include (backport) #16723 too.