George Steel

Results 207 comments of George Steel

One drawback to using a stub is that PHPStorm picks it up and marks everywhere you use a `ContainerInterface` with a multiple implementation warning, not only in the library hosting...

Good idea! Or export-ignore it in `.gitattributes`

Failures here will be solved by #121

I'm not actually a maintainer for `laminas/view`, just a contributor so paging @weierophinney and @froschdesign for their input. My personal initial reaction is generally 👍, with the exception that a...

OK - Feel free to close unless you want to leave the issue hanging for the next major :)

Is it planned to get composer-require-checker installed by default in the ci-action container?

That's great news - getting it installed on older PHP versions is a pain. So once implemented, it'll run require-checker on 8.0 as opposed to the matrix default stable?

> I just noted that this package does not depend on `psr/http-message`, which is only in `require-dev`: > > https://github.com/laminas/laminas-validator/blob/23e27edc1520c0bf0c9c7e7f192dd1314677969e/composer.json#L50 > > I think declaring the dependency, although annoying, would...

> Not if a new major version breaks BC there :| Good point - tests wouldn't catch that because dev is pinned to ^1