Greg Smith comments

Repositories
Issues
Comments

Results 2 comments of


                                            Greg Smith

RequestPatternBuilder has ability to clear/replace underlying Collection types.

Thoughts on this change @tomakehurst / @oleg-nenashev ? Any preference on the options I've proposed. I'm willing to make it if you're willing to pull it.

RequestPatternBuilder has ability to clear/replace underlying Collection types.

Just to be clear, you're suggesting: 1. Remove `withRequestBody(ContentPattern contentPattern)` 2. Add `withRequestBodies(Collection contentPatterns)` and taking a defensive copy (i.e. `ImmutableList.copyOf(contentPatterns)` in the Builder setter. 3. We'd make this change...