Guilherme Salgado

Results 12 issues of Guilherme Salgado

That function seems to add a big overhead to `keccak()`, and given its performance-critical nature I think we should consider dropping it (making keccak() accept only `bytes`). Here are some...

Good First Issue
p3

They were failing intermittently, so had to be disabled.

Issues #1961 and #1962

``` WARNING 2020-11-27 22:38:10,568 Chain Proposed Block #11343248-0xf90d..0cdc doesn't follow EVM rules, rejecting... : task serve[daemon=True] exited with error: Mismatch between block and imported block on 3 fields: - header.state_root...

Trying to incrementally build clique blocks fails (the state root will be wrong on the final block) because the initial header is not signed so all tx fees are incorrectly...

When incrementally building clique blocks, the meta witness returned by `mine_block_extended()` is always empty. That works correctly for PoW blocks

We have no unit tests for most Chain methods; it'd be good to have some at least for the methods that deal with block retrieval/import/validation

Probably Close

Current implementation doesn't capture discv5 frames. ISTM `dissect_ethereum_heur()` returns false for them, but we'd also need to add support for the v5 commands

Neither CreateSocket() nor any of the metrics-generating methods (i.e. Timing(), Incr(), etc) return an error when there's no statsd listening on the address given when creating the client, as can...