Grzegorz Kołakowski
Grzegorz Kołakowski
What's more, if we have a string broken by backslashes into multi-line token, the location of the following tokens is wrong. Example: ``` 4: char *string = "a \ 5:...
@alpreu Hey! Could you tell me what is the status of this pull request, please? Thanks!
> Hi @grzegorz8, I'm not actively working on Flink anymore. I think this PR was kept open as we were waiting to move the ES connector to the [external repo](https://github.com/apache/flink-connector-elasticsearch)....
@MartijnVisser Hi! I've fixed code formatting, so I think build can be rerun now. Thanks!
@eskabetxe Could you review the PR, please?
> Hi @grzegorz8, thanks for your contribution. I left some comments > > but should be this PR on https://github.com/apache/flink-connector-elasticsearch ?? I just thought flink-connector-jdbc is the most suitable place...
Due to recent refactoring it was easier to create a new PR: https://github.com/apache/flink-connector-jdbc/pull/136 Closing this one.
> @kristoffSC @MarekMaj hope to get to this this week. Thanks for your feedback. Hey @davidradl! Do you plan to continue working on the PR anytime soon? I can take...
@davidradl Hey! Thank you for addressing this feature - it would be great to have it in the connector. Overall, all the points you mentioned look good. However, I have...
> I still have some doubts about: > * whether this should be part of the Elasticsearch connector: "https://github.com/apache/flink-connector-elasticsearch." > The recent refactor makes this feasible, as you only need...