grok45
Results
3
comments of
grok45
> We will want to add some regression tests too, before we commit any changes. > > You can start looking/reading/familiarizing yourself with these: > https://github.com/apache/mesos/blob/master/src/tests/zookeeper.hpp > https://github.com/apache/mesos/blob/master/src/tests/zookeeper_tests.cpp > >...
OK. I propose I am going to add a unit test for the new parsing logic and we'll merge this pull request. If you want to develop a better approach...