grigory

Results 9 comments of grigory

@znerol hi there. if parameter changed [GUI or CLI] on active VM the parameter applied without delay. you can change it on the fly. for example: `qm set 533 -virtio1...

@znerol thanks for reply. Collecting limits metrics is really useful for some Proxmox installation. Do you have any idea how to reduce data collection time?

@znerol thank you for ideas. if default disable gather this metrics set `default=False` e.g. ``` parser.add_argument('--collector.iolimit', dest='collector_iolimit', action=BooleanOptionalAction, default=False, help='Exposes PVE io limit') ``` and make notion in README about...

confirm, on large installation scrape inefficient ``` .... # HELP pve_mbps_wr_max Proxmox vm config mbps_wr_max # TYPE pve_mbps_wr_max gauge pve_mbps_wr_max{device="virtio",device_name="virtio0",id="qemu/273",node="pve04-z601",type="qemu"} 30.0 real 0m6.366s user 0m0.010s sys 0m0.005s ```

@znerol I have a proposition for you. let's combine `--collector.config` and `--collector.iolimit` to save time and make these options `default=false` I can make PR. What can you say about it?

@znerol good day. what about disable metric collection in default config?

@znerol good day. Please see question below.

resolves [#115](https://github.com/prometheus-pve/prometheus-pve-exporter/issues/115)