Gregory Farnum
Gregory Farnum
> > @tshacked Genrally, the use of `using` in header files is considered a _bit_ off-putting. > > > WDYT? > > Actually. I wasn't aware of it. > >...
> @gregsfortytwo I heard you might be a good person to review the monitor code changes in this PR? I don't have anything but @kamoltat 's question about s/out/err/.
@Madhu-1 would this be okay with CSI? It really simplifies our life but I don't know if it'll be okay for users on top of us.
This is the right basic idea, but as @batrick says it's not quite correct.
> Doing this work in `rmsnap` is not going to work well when the # of strays is very large. (In fact, it probably shouldn't happen in mds boot either!)...
> > > > Just a small question to @thmour If rctime is updated manually, that rctime has to bubble up to the root dir or snap-root dir appropriately. I...
Hm, I don't have any comments on the details, but at a bigger picture: why store the snap_mtime in the parent inode? Alternatives: 1) store the mtime in the SnapRealm...
> > 2. Do we actually _need_ snapdir-specific metadata? What are the downsides of just using the CInode's mtime and change attr? > > Do you mean parent dirs mtime/change_attr?...
> > > > 3\. Do we actually _need_ snapdir-specific metadata? What are the downsides of just using the CInode's mtime and change attr? > > > > > >...
On Mon, Oct 10, 2022 at 10:48 PM Venky Shankar ***@***.***> wrote: > > 1. Do we actually *need* snapdir-specific metadata? What are the > downsides of just using the...