Greg Jones
Greg Jones
It sounds good to me. Do you think you'll be able to work on this?
@oyvindio Yes, I missed that part. It's deleted with 5b79aa54f978d4ef650ae0db1c59e8e376edf453
Thanks for the reviews. As mentioned elsewhere, I'll wait on merging this until we are ready to trigger re-deploys of the apps in our clusters, I think it's relatively harmless...
I gave this a spin locally, and it seems ok. Is there anything missing still you know of?
> For how long should FDD be watching for liveness/readiness check failures? I think the existing behaviour of `ReadyCheck` is fine for this, it's just an extra thing for it...
2 seems quite consistent with how things work now, and quite simple to implement (and to understand/document). But does it require some change in the datadog config part too, at...
But for the application to send the metrics to the statsd agent, it needs to be told the host/port - currently fiaas sets these env vars in the app's container....
Please create your own fork to add any new functionality, I'm not interested in making more changes here.