greenmarmot comments

Repositories
Issues
Comments

Results 2 comments of


                                            greenmarmot

[BUG] 1.5.1 uses log.Printf

@AlexVulaj Commit https://github.com/gorilla/websocket/commit/666c197fc9157896b57515c3a3326c3f8c8319fe changed package functionality with no documentation on why the functionality was changed. Some of these changes have been harmful (https://github.com/gorilla/websocket/issues/852, https://github.com/gorilla/websocket/pull/863, https://github.com/gorilla/websocket/issues/877, https://github.com/gorilla/websocket/pull/865, https://github.com/gorilla/websocket/issues/867). I understand that...

Graceful shutdown of the websocket connection.

How to implement: Add field to Upgrader and Dialer: CloseTimeout time.Duration Add field to Conn: maxReadDeadline time.Time When a close message is sent, CloseTimeout is not zero, and maxReadDeadline is...