Denys Zadorozhnyi
Denys Zadorozhnyi
I'd like to take this one.
@therealyingtong I took a shot at it (#663), and I'm stuck with two questions. I'll copy them from #663: 1. for `WitnessCollection::advice`, there is what looks like a similar operation...
> @greenhat > > 1. Yes, unusable advice cells are already set to random values; Ok, so I'm scraping my changes to `WitnessCollection`. > > 2. We should only initialise...
Thank you for the code suggestions! I updated the PR and removed keygen-related changes. However, the `plonk_api` test is failing with `proof generation should not fail: ConstraintSystemFailure`.
Thank you for your patience and comprehensive explanation! I've updated the PR, and now I'm getting: ``` test plonk_api ... FAILED failures: ---- plonk_api stdout ---- thread 'plonk_api' panicked at...
It did the job. Thank you! I updated the PR, and it's ready for review.
I found wartremover super useful. @EzequielPostan nice list, `Recursion` wart deserves a mention too. It forces you to think about stack safety in every recursion.
@ceilican I agree. And it might be a good idea to create ticket(s) for "warts to enable" list.
Due to the following reasons: 1. GLIBC being too old(2.28) on CentOS 8 oracle binary build on Fedora 36 is crashing. 2. To ensure all testers are running the same...
First run UX is not great: #62 #63