Grant Lucas comments

Results 16 comments of


                                            Grant Lucas

"$" not properly escaped

Only thing I've been able to come up with so far is that the input from the start needs to have the dollar escaped with a back slash. Kind of...

Option to disable directory index routing

Any word on the possibility of incorporating some of the open Pull Requests? Thanks. :smile:

Option to disable directory index routing

@tiger-seo I tried messing with it a bit to update this PR to match your recommendation but am having an issue. - Whenever `~` is used as a value, it...

Option to disable directory index routing

:+1: sounds good to me. Will work on that patch

Option to disable directory index routing

@tiger-seo This PR has been updated to match your recommendation. Only issue I ran into was that `off` was getting converted to an empty string when passing it through `-dcodecept.directory_index`....

Question regarding the shutdown function vs destruct's stop server

Thanks! Another question. Instead of calling just `proc_terminate()` in the shutdown function, would calling `stopServer()` make sense to ensure it all get shut down properly in each case? I haven't...

Sidestep not recognizing VPN

I'm seeing this as well. Any new VPNs never show up in the list

Don't try to run PhantomJS if there's already something running at the same port

Though Phantoman _could_ be set up to automatically detect an open port, I'm not sure if it would work with WebDriver. The issue is that the WebDriver module and Phantoman...

Don't try to run PhantomJS if there's already something running at the same port

Ah true. Alright, that would be possible! I'll look into getting that added.

Refactored and Updated

Thanks for the PR. I'll need to give it a review in the next few days.