Grant Cleary
Grant Cleary
I'll deal with the vdiff goldens if we determine we're alright with this (or alternatively if we've figured out a better path forward).
> I think I'm following this mostly, and am not having a "flash of insight" on another innovative approach. Not going to lie; I was kind of hoping I was...
> Hey Grant, apologies for the delay looking at this. Just getting my bearing... is there any chance you can attach a screenshot showing the issue we're trying to solve?...
@dbatiste, sorry for the delay... I was trying to get a screenshot on my LMS instance where the issue is way more pronounced, but I realize I had wiped out...
> I agree though... in retrospect it seems like a lot of hackery -- although ultimately if all this helps us clean up what grades is doing and bring everything...
Given that we seem to have grudgingly accepted this as the way forward, I'll make those test changes and clean up vdiff as necessary. I'm leery about merging something like...
... I mean vdiff failed, but is it just me, or do the existing goldens just look broken?
> Agreed! It looks like it was me who did that and I'm not sure why. They now look correct to me. Cool beans. Wanted to make sure I wasn't...
@dbatiste, @dlockhart - I think this should be good to go now, unless I've forgotten/missed something.