Graham Langford

Results 24 comments of Graham Langford

Can you ping #engineering letting everyone know about the version bump when you merge?

We'll keep this one on the back-burner for now. Once other low-hanging fruit have been fixed, we'll try again.

As of https://github.com/pixiebrix/pixiebrix-extension/pull/6590, there are still 605 errors that would need to be resolved.

Need to remove temporary typing in `src/sidebar/messenger/registration.ts`. See https://github.com/pixiebrix/pixiebrix-extension/pull/6650/files#r1355092186

> We can unblock many of these files by creating additional entry points for common methods like `recordEvent`, which is imported directly by 60 files: > > ```diff > -...

@BLoe I'd like to get your opinion on the Expected Behavior

The toast is not in a shadow dom. We don't have this problem with the Snippet Shortcut Menu, and it's in a `mode=open` shadow dom. I would be against requiring...

@BLoe is there a Postman collection with the relevant APIs?

Works on Mac Edge, but not PC Edge. `Ctrl + M` is a default Shortcut in Edge for muting the tab, but `Cmd + M` is also a default shortcut...

After doing some research, the problem appears to be that an empty string for a non-required field is still considered valid by yup. @cf-worker's validator also seems to deliver the...