Gustav Paul comments

Results 5 comments of


                                            Gustav Paul

Fix flaky tests: don't rely on map iteration order.

Please merge this patch.

Support "shouldFail" for Command

Maybe something like ``` apiVersion: kudo.dev/v1alpha1 kind: TestStep commands: - command: ../../bin/dispatch login github --user=test --password=test # Test that duplicate login fails. - command: ../../bin/dispatch login github --user=test --password=test expectedExitCode:...

Add gracePeriod or timeout to error steps

Unfortunately not - I thought about that too but the problem is that there is a race condition. Once my object B is created from my object A, there is...

Restrict assert with apiVersion/kind to only relevant objects

Hey :-) Sure, so I have the following assert.yaml: ``` apiVersion: tekton.dev/v1beta1 kind: PipelineRun metadata: labels: repository-ref: dispatch spec: resources: - name: git serviceAccountName: github-webhook timeout: 1h0m0s status: conditions: -...

`GetCapacityResponse` should contain "total capacity"

> If there is only one way to allocate the volume from a storage class, then we can report the capacity for this storage class. The CO can cache them...