Gorka Bengochea
Gorka Bengochea
Hey @DouweM! Thanks for the thorough review. I've gone through all your comments and made the changes across 7 commits. **What I fixed:** - Cleaned up the docs (added links,...
**Integration tests update:** I've added `@pytest.mark.vcr()` decorators and proper resource creation/cleanup to both OpenAI and Gemini `FileSearchTool` integration tests. The tests are structured correctly and will record cassettes when run...
re @DouweM Done! **uv.lock**: Reset, updated uv to latest, ran `uv lock` again. Diff is now minimal. **Tests**: Refactored to match the built-in tool test pattern: - Non-streaming with full...
Hi @DouweM !! 🙋♂️ All requested changes are complete: - Added file upload examples for OpenAI (using model.client) and Google (using model.client.aio.file_search_stores) - Renamed vector_store_ids → file_store_ids throughout the codebase...
@DouweM all feedback reviewed! Let me know when you can re-record the cassttes and if you spot anything else we can improve! great teamworkkk
Hey @DouweM! I've fixed the issues: > 1. ✅ OpenAI vector_store_ids fix - Changed to use the correct parameter name when calling OpenAI's API > 2. ✅ Pyright deprecated class...
Hey @DouweM ! I finally recorded the cassettes myself, all good now. Let's see what CI has to say now Thanks!
@DouweM let me know if there's anything else I can do!
I have to say the same @DouweM !! Thank you! It was very insightful to collaborate with you on this PR!! 🤗🤗