Gordon Rennie

Results 7 comments of Gordon Rennie

> Question on this concerning the stub files. Why can't you change the library root to a directory specific to a type of board and that directory would contain the...

I have done some code analysis for serialisation: * `fs2-kafka-vulcan` interfaces with the Java code here: https://github.com/fd4s/fs2-kafka/blob/de26d891bdf4f28585371d7e480ef99c324010f2/modules/vulcan/src/main/scala/fs2/kafka/vulcan/AvroSerializer.scala#L26 * `F.pure(serializer.serialize(topic, value))` doesn't seem quite right to me - `serializer.serialize` calls into...

> I agree - a PR would be very welcome! :+1: thanks for the feedback! I am happy to take a crack at this (I will also review and include...

Hi @bplommer, we spoke about this issue in https://github.com/fd4s/fs2-kafka/issues/663 - I'm curious to know how you feel the PR turned out? It sprawled a little due to adding configuration of...

> Hi @gordon-rennie - so sorry for dropping the ball on this! I'll do my best to look at this properly over the weekend. No worries at all, thanks!

Closing as master has drifted significantly - the last time I reviewed the situation, new changes on master made this approach unattractive and it would be better implemented by having...

> Isn't it the same issue as https://github.com/micrometer-metrics/micrometer/issues/1882 ? I can still repro this issue on `1.11.0` and `latest.integration` builds, so sadly no; this issue is unfixed and outstanding. I...