goldsteinn
goldsteinn
Not a maintainer so take this with a grain of salt. From a quick glance at the source it looks like the only affect of nonblocking read is that it...
The test failure seems to be because of the changed hash result. I think this is expected because the loop count change but someone should double check.
> Changing the value of the hash will indeed fail the tests. Hi, can you comment on whether its an issue in this case? I believe the hash value changes...
> > Hi, can you comment on whether its an issue in this case? > > It is. `xxHash` is labelled "stable" for a reason : so the produced hashes...
@Cyan4973 I'm going to start maintaining a fork [xxHash-Unstable](https://github.com/goldsteinn/xxHash-Unstable). Aside from the inclusive calculating of `nbRounds` in the `129to240` case, do you know of any other perf gains that have...
LGTM. Wait on one more.
> I stand corrected, MSVC does seem to still optimize for a generic CPU. The problem is with our `tr_popcnt::count()` that uses the builtin w/o a proper cpuid check at...
> @goldsteinn could you make a PR against `main` please? bow Sure, see: https://github.com/transmission/transmission/pull/4886