gndrmnn

Results 13 comments of gndrmnn

Needed: https://github.com/osism/terraform-base/pull/54

``` PLAY [Apply bootstrap roles part 1] ******************************************** TASK [osism.commons.hostname : Set hostname_name fact] ************************* Wednesday 15 May 2024 13:29:10 +0000 (0:00:02.227) 0:00:16.977 ********* ok: [testbed-node-0.testbed.osism.xyz] ok: [testbed-node-1.testbed.osism.xyz] ok: [testbed-node-2.testbed.osism.xyz]...

https://github.com/osism/terraform-base/blob/c6062af528396af20054167036d497678fa07202/testbed-default/manager.tf#L71-L121 https://github.com/osism/terraform-base/blob/c6062af528396af20054167036d497678fa07202/testbed-default/customisations/default_custom.tf#L21-L49

@frittentheke Hi, > With the use of the web-download mechanism of Glance images are usually not downloaded by the image-manager but by Glance itself. I'd refrain from adding any code...

@frittentheke This was discussed with @berendt and it was decided that we implement this PR as is. The hash values in the yaml files will be pre-computed by the GitHub/Zuul...

> I'm wondering whether the file should be downloaded AFTER the filename is determined (after the whole HEREBE DRAGONS stuff). Or am I missing something? If I understand you correctly,...

> @gndrmnn > > > If I understand you correctly, it should make no meaningful difference at which of those two points in time the file is downloaded and hashed....

@mbuechse I would kindly ask you to review this Merge Request as you are most familiar with the refactored update.py :) The current iteration of this MR adds an additional...

Why _on earth_ did the PEP8 issues not trigger the Flake8 test?? :thinking:

> > Why _on earth_ did the PEP8 issues not trigger the Flake8 test?? 🤔 > > Maybe your fork somehow didn't include the CI triggers? Nope, the flake8 test...