Gray Mackall

Results 194 comments of Gray Mackall

I'm not able to reproduce this, likely because the example app in question https://github.com/flutter/packages/blob/d4cd4f00254b2fdb50767c837ecd27bcbac488cd/packages/google_maps_flutter/google_maps_flutter/example/android/app/build.gradle#L33 already has minSdkVersion set to 20. Is your packages repo out of date? Can you post...

> > I'm not able to reproduce this, likely because the example app in question https://github.com/flutter/packages/blob/d4cd4f00254b2fdb50767c837ecd27bcbac488cd/packages/google_maps_flutter/google_maps_flutter/example/android/app/build.gradle#L33 already has minSdkVersion set to 20. > > Is your packages repo out of...

Hmm I think I can see what might have happened - did you test this on master, and then on stable? I see you mention both master and stable in...

It seems like the ShimPluginRegistry is used when an app w/ embedding 2 is using a plugin w/ embedding 1, therefore making it probably also fair game to delete? https://github.com/flutter/flutter/blob/f38c5ad44141d3b7711dddd5bbf9c8862a5ed68a/packages/flutter_tools/lib/src/flutter_plugins.dart#L401...

This will be blocked until I finish and land https://github.com/flutter/flutter/pull/144726, but should be ready for review now. Please inform me if you believe I've deleted something that shouldn't be deleted.

> It seems like the ShimPluginRegistry is used when an app w/ embedding 2 is using a plugin w/ embedding 1, therefore making it probably also fair game to delete?...

[Looks like there was a doc here](https://github.com/flutter/flutter/wiki/Upgrading-pre-1.12-Android-projects), and another at go/flutter-delete-android-v1-embedding (I've requested ownership)

Just waiting on one more internal CL to land 🙏

Last internal CL has landed, so this is unblocked. I've removed framework code referencing the v1 embedding, and removed internal uses, so at this point the path should be cleared...