Kirill Khramkov

Results 9 comments of Kirill Khramkov

Should this be addressed? if so I would like to help.

```ts function generatePathStrict( originalPath: Path, ...params: PathParam extends never ? [object?] : [ { [key in PathParam]: string | null; }, ] ) { return generatePath(originalPath, params); } ``` This...

I opened a MR that fixes this issue. It's awaiting approval. Don't close.

I would like to contribute to this. Was trying to implement this myself, but overwriting type of t returned from the hook is the pain in the ass.

Where do you expect this to be rendered?

Probably need to set transfer type to binary before resuming. Will look into it.

Fixed for sqlite and postgres in #1298 DuckDB requires additional research, seems like problem in their crate

Issue with query builder: ![image](https://github.com/spiceai/spiceai/assets/20399045/c1081414-7fb9-44a6-9999-420829d8719a) Same for other data connectors

Ok I will be mindful of that. Didn't do much fiddling with jsdoc typing before. I think you can define typescript types separately and import them in jsdoc.