George Barnett

Results 42 issues of George Barnett

Motivation: UUIDs are often sent over the wire but writing and reading their bytes to/from a buffer is a bit of a pain: the obvious solution is grabbing the underlying...

🔼 needs-minor-version-bump

There are times when it's beneficial to modify the readable contents of a `ByteBuffer` in-place. This can currently be done with `withUnsafeMutableReadableBytes`. We also have `ByteBufferView` which is both a...

performance

The `EventLoopGroup` protocol has two requirements which relate to iterating over loops in the group: - `next()` produces an `EventLoop` in an infinite sequence - `makeIterator()` returns an `EventLoopIterator` for...

⚠️ needs-major-version-bump

These were missed when we went from NIO 1 to NIO 2: ```swift public struct ByteBuffer { ... // these two type aliases should be made `@usableFromInline internal` for //...

⚠️ needs-major-version-bump

`HTTPClientTests.testVaryingLoopPreference` occasionally fails with: ``` AsyncHTTPClientTests/HTTPClientTests.swift:1452: error: HTTPClientTests.testVaryingLoopPreference : failed - Unexpected error: invalid constant string AsyncHTTPClientTests/HTTPClientTests.swift:1452: error: HTTPClientTests.testVaryingLoopPreference : failed - Unexpected error: invalid constant string AsyncHTTPClientTests/HTTPClientTests.swift:1452: error: HTTPClientTests.testVaryingLoopPreference...

area/testing

When adding metrics to an application or framework it would be useful to have some indication of the metrics emitted during execution to serve as a basic sanity check ("when...

Pseudo headers must appear at the beginning of a block of headers. However, there's no API in `HPACKHeaders` to allow for this; it requires up-front knowledge that when constructed the...

kind/enhancement

Both `HTTPHeaders` and `HPACKHeaders` have very similar APIs. One slight difference is that `HTTPHeaders` `subscript(canonicalForm:)` returns `[Substring]` while `HPACKHeaders` returns `[String]`. Returning `[Substring]` would allow us to potentially avoid some...

kind/enhancement

In the NIO-based client, waiting for the RPC to terminate via the `status` future is a little clumsy: - The documentation states that it should never be failed, so if...

enhancement

### Describe the bug - `testBidirectionalStreamingOnCloseAfterUserFunctionFails` seems to get stuck when run in CI and eventually times out. - This doesn't happen consistently but does happen quite frequently. ### Additional...

kind/bug