Gopikrishnan NS

icon location My at-work CV: https://www.linkedin.com/in/nsgopikrishnan/ I sometimes scribble notes at: https://medium.com/@gkns

Results 3 comments of Gopikrishnan NS

With Custom Repo when `Check remote` is disabled the link generated is always with the commit ID in URL

Upon looking at the code, may the below be a fix? Location https://github.com/ben-gibson/GitLink/blob/6cfac49a6102f4c9d4ac162fe3770603b7cd561a/src/main/kotlin/uk/co/ben_gibson/git/link/pipeline/middleware/GenerateUrl.kt#L48 change the condition : ``` if (commit != null) { UrlOptionsFileAtCommit(baseUrl, repositoryFile, commit, context.lineSelection) } else {...

With Custom Repo when `Check remote` is disabled the link generated is always with the commit ID in URL

Hi, @ben-gibson, Any ideas to fix this locally as an interim measure?

With Custom Repo when `Check remote` is disabled the link generated is always with the commit ID in URL

Thank you! Acknowledge. For now, I have made the following tweaks in the custom-domain template and it works. ``` File at branch template : https://gitlab.eng.vmware.com/core-build/{remote:url:path:1}/-/blob//{file:path}/{file:name}#L{line:start}-L{line:end}{line-block:end} File at commit template: https://gitlab.eng.vmware.com/core-build/{remote:url:path:1}/-/blob/{commit}/{file:name}{line-block:start}#L{line:start}-L{line:end}{line-block:end}...