Dallas
Dallas
> LGTM! The only thing I noticed is if I try to enter a value in that input manually and hit backspace to enter a new number, it replaces the...
@mcarrano - in this PR i've utilized the textinput inside of the numberinput... however, there is logic within InputGroup is checking whether any (non select/textarea/textinput) children have an ID and...
@mcoker - i agree about inputGroup should not be so opinionated, and found it odd to have it automatically generate describedby on a button id. As far as disabling that.....
@mcoker - this would override the describedby passed in `inputProps`... but I suppose if we add your `disableAssignDescribedby` or something it could be used together... or maybe just letting `inputProps.describedby`...
TLDR on coker and my exchange, our final options were narrowed down to: 1. allow `inputProps['aria-describedby']` to persist over the automatic describedby creation this would basically mean changing [this line...
I went ahead and just made it so that if someone adds aria-describedby to the input props, they don't get overridden by the existing feature. Seems least invasive for this...
Edit: nevermind this - i just dug and found out that text input does the error differently than warning/success
That error is because you didn't update the null check to be an undefined check. I prefer using undefined personally.
Although I'm unsure what people may want to add to the expansion variant other than a string, I don't want to assume people won't have some requirement to do so....
@thatblindgeye - seems like we need some design input here? Personally I think the "label above" example you showed makes a lot of sense, and wouldn't even require any change...